ggplotly not recognizing color as aesthetic mapping
#2034
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpsievert
requested changes
Oct 8, 2021
There was a problem hiding this comment.
It'd be better if this logic were closer to the actual tooltip text construction, probably here
Lines 27 to 29 in c35a44e
|
@cpsievert done |
|
@moutikabdessabour in the future please update the |
|
@cpsievert sorry but I figured everything was resolved. |
|
It's ok, but please start a new PR that adds news items for the 2 PRs that you merged |
|
Ok will do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2031. ggplot internally converts
colortocolour. Note that running the tests locally results in the deletion of_snapfolder. @jackparmer @cpsievert. Maybe I should stop usinggit commit -am